fix: Preserve __alias__ when mapping streams with repeated schema messages
#1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanilJr
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1524 +/- ##
=======================================
Coverage 85.50% 85.51%
=======================================
Files 57 57
Lines 4692 4693 +1
Branches 802 802
=======================================
+ Hits 4012 4013 +1
Misses 489 489
Partials 191 191
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
approved these changes
Mar 24, 2023
There was a problem hiding this comment.
Hey @DanilJr!
Thanks for the PR. Just one question. Otherwise this looks good 🙂
edgarrmondragon
changed the title
__alias__ is when mapping streams with repeated schema messages
|
I would like to have automated tests but at least manual testing confirms that the patch works as intended: 1. Singer input{"type": "SCHEMA", "stream": "example", "schema": {"properties": {"id": {"type": "integer"}}}}
{"type": "RECORD", "stream": "example", "record": {"id": 1}}
{"type": "SCHEMA", "stream": "example", "schema": {"properties": {"id": {"type": "integer"}}}}
{"type": "RECORD", "stream": "example", "record": {"id": 2}}2. Stream config{
"stream_maps": {
"example": {
"__alias__": "example_v2"
}
}
}3. Mapper output{"type": "SCHEMA", "stream": "example_v2", "schema": {"properties": {"id": {"type": "integer"}}}, "key_properties": [], "bookmark_properties": []}
{"type": "RECORD", "stream": "example_v2", "record": {"id": 1}, "time_extracted": "2023-03-24T19:41:37.953424+00:00"}
{"type": "SCHEMA", "stream": "example_v2", "schema": {"properties": {"id": {"type": "integer"}}}, "key_properties": [], "bookmark_properties": []}
{"type": "RECORD", "stream": "example_v2", "record": {"id": 2}, "time_extracted": "2023-03-24T19:41:37.953966+00:00"}I can also confirm that using a explicit shallow copy ( |
edgarrmondragon
changed the title
__alias__ is when mapping streams with repeated schema messages__alias__ when mapping streams with repeated schema messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It relates to this issue
Closes #1521
📚 Documentation preview 📚: https://meltano-sdk--1524.org.readthedocs.build/en/1524/